ShadowPagingRegion: improve concurrency #761
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mn data contains an exactly sized array
reads will never* block, even with concurrent writes. writes will only block while waiting for the previous group of reads to complete, or while waiting for a previous write to complete. *reads will block if there is a concurrent write doing writeSpecial, however this is completely irrelevant as writeSpecial is never actually used.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
reads will now never* block, even with concurrent writes. writes will only block while waiting for the previous group of reads to complete, or while waiting for a previous write to complete.
i'd like some code review on this one, i've double-checked this more times than i care to count and i haven't encountered any issues in testing, but i'd still like a second opinion before this is merged.
*reads will block if there is a concurrent write doing writeSpecial, however this is completely irrelevant as writeSpecial is never actually used.