Manage the institution specific vetting type hints #290
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The data is processed into a command and sent of to middlewares command pipeline. In order to make the form function more intuitively. We read the hints for the relevant insittution into the form. This way an user can modifiy the existing text.
MKodde
force-pushed
the
feature/sat-institution-vetting-text
branch
from
d627d10 to
4a848b3
Compare
As a means to clear the vetting type hint, we should allow posting an empty hint in order to remove it.
MKodde
force-pushed
the
feature/sat-institution-vetting-text
branch
from
4a848b3 to
3d0e187
Compare
pablothedude
approved these changes
Jul 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An institution can have a translatable vetting type hint. This hint is displayed at the right place in the self service. A new tab was added to the RA app. Here you can choose an institution. The vetting type hint for that institution is then loaded. No formatting additions where added yet. This however is something to add later on (see new story). Users are allowed to remove a vetting type hint by simply clearing the previous entry in the textarea and saving a blank set of translations.
The available translation options follow the locales configured in the
parameters.yaml. For now en_GB and nl_NL are configured by default. But adding/removing languages should not be any issue and do not require additional database migrations. As the hints are stored in a JSON blob in thevetting_type_hintsschema in Middleware.See: PR for details on the SS changes.
See: https://www.pivotaltracker.com/story/show/182840207