Implement recovery token revocation #286
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was a simple matter of calling the existing revoke endpoint on Middleware. Some new boilerplate was created to facilitate this in RA. A form was added that is triggered by clicking 'continue' in the modal window. Some filthy JQuery code was copy pasted from the similar SF revocation solution. This code picks up the recovery token id, actor id and identity id (the one possessing the RT). And sets the values on the hidden revocation form. A command was added that is filled with the form. And it contains the data required to revoke the token. This command is then posted onto the Middleware api (command endpoint) after being translated into a correct MW command in the client bundle. Translations where updated. https://www.pivotaltracker.com/story/show/181968091
MKodde
force-pushed
the
feature/sat-revoke-token
branch
from
7c34636 to
ed77cee
Compare
pablothedude
approved these changes
Jul 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was a simple matter of calling the existing revoke endpoint on Middleware. Some new boilerplate was created to facilitate this in RA.
A form was added that is triggered by clicking 'continue' in the modal window. Some filthy JQuery code was copy pasted from the similar SF revocation solution. This code picks up the recovery token id, actor id and identity id (the one possessing the RT). And sets the values on the hidden revocation form.
A command was added that is filled with the form. And it contains the data required to revoke the token. This command is then posted onto the Middleware api (command endpoint) after being translated into a correct MW command in the client bundle.
Translations where updated.
https://www.pivotaltracker.com/story/show/181968091