Fix multiple testing issues with the current GH Actions workflow and Composer scripts #274
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously commands were not executed within the docker container but outside of it on the virtual environment of github. Now all the tests will be done on the actual container
VadimSchmitz
changed the title
VadimSchmitz
force-pushed
the
bugfix/tests
branch
from
1ea1d41 to
3657b0f
Compare
MKodde
requested changes
Mar 15, 2022
| @@ -44,7 +43,7 @@ jobs: | |||
| - name: Build frontend assets | |||
| run: cd ci/docker && docker-compose exec -T stepup-ra bash -c 'source "/usr/local/nvm/nvm.sh" && yarn encore production' | |||
| - name: Run test scripts | |||
| run: cd ci/docker && docker-compose exec -T stepup-ra bash -c ' composer test ' | |||
| run: cd ci/docker && docker-compose exec -T stepup-ra bash -c ' composer test && source "/usr/local/nvm/nvm.sh" && yarn audit ' | |||
There was a problem hiding this comment.
I guess this commit can be dropped. As the source issue was later resolved.
ci/qa/security-tests
Outdated
|
|
||
| "wget -q https://github.com/fabpot/local-php-security-checker/releases/download/v1.0.0/local-php-security-checker_1.0.0_linux_amd64 -O local-php-security-checker && chmod +x ./local-php-security-checker && ./local-php-security-checker", | ||
| source "/usr/local/nvm/nvm.sh" | ||
| yarn audit |
Comment on lines
6
to
8
| defaults: | ||
| run: | ||
| shell: bash -l {0} |
There was a problem hiding this comment.
This can be removed, that was part of my R&D work.
ci/docker/docker-compose.yml
Outdated
Comment on lines
6
to
8
| stepup-ra: | ||
| stdin_open: true | ||
| tty: true |
There was a problem hiding this comment.
Please try removing this option. I do not believe it being critical.
VadimSchmitz
force-pushed
the
bugfix/tests
branch
from
3657b0f to
0a28c74
Compare
MKodde
reviewed
Mar 15, 2022
ci/qa/security-tests
Outdated
| printf 'Curl failed downloading php-security-checker with error code "%d"\n' "$?" >&2 | ||
| exit 1 | ||
| fi | ||
| source "/usr/local/nvm/nvm.sh" |
There was a problem hiding this comment.
One final leftover that can now be removed as per bash -l
by adding the -l flag to the docker exec command there is no longer a need to source for yarn each time it is called
VadimSchmitz
force-pushed
the
bugfix/tests
branch
from
0a28c74 to
896f8b7
Compare
|
Inspecting the GHA output. I see Sebastian CPD throwing a fatal error. |
VadimSchmitz
force-pushed
the
bugfix/tests
branch
from
7f67a0d to
1ebc344
Compare
PHPCPD was no longer functioning due to Xdebug 3 not supporting the version of PHPCPD we are using. PHPCPD could not be updated due to the projects PHP version not allowing it. Therefore there is chosen to replace PHPCPD with JSCPD.
VadimSchmitz
force-pushed
the
bugfix/tests
branch
from
1ebc344 to
7987f03
Compare
|
With the newest commit PHPCPD has been replaced with JSCPD, See latest commit for an explanation. |
The correct folders are now ignored, a limit of 30 duplicates is set for triggering a duplication warning. Breaching a project wide duplication treshold of 1% will start causing the copy paste detector to exit with a 1 status code
MKodde
approved these changes
Mar 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed 5 issues and added 1 feature
Workflow now installs dependencies and tests them on the container instead on the vm.
Yarn audit was not working properly due to a bash quirk.
Xdebug is now installed and enabled so the code coverage tests work as intended.
Other security audit now actually works instead of exiting with 0 even when it didn't run.
Moved local-php-security-checker to its own bash file instead of having a script in composer.json.
Replaced PHPCPD with JSCPD, due to Xdebug^3.0 PHPCPD would no longer work and therefore it is not replaced.