Configuration to run tests in Github Actions #271
Conversation
adds docker compoer file that will be used for the conversion from travisci to github actions
VadimSchmitz
changed the title
There was a problem hiding this comment.
Awesome work Vadim.
Feel free to merge this and fix the two pointers on your next PR. That way you don't have to rebase your current work onto these changes.
Edit:
Looking at your commit messages, I have some critique:
- The title of your first commit
Add docker-composeris not doing it for me. I can deduct that you are adding something related to docker-composer. But consider making it more descriptive like:Create the test-integration docker-compose.yml fileor something along those lines. Short is not always better (but it often is ;) ) - Try to re-read your commits and do some self-reviewing. That way you can catch some typos, maybe further sharpen a title, or even come to the conclusion that your commit needs to be squashed or otherwise modified.
You have come a long way in 7 days! These pointers are not to bring you down but just to raise the bar a little bit 👍
| ## ant should be changed to a composer script somehow | ||
| - ant | ||
| - composer test | ||
| on: [ pull_request, push ] |
There was a problem hiding this comment.
This will do the job just fine. But maybe to preserve some GHA clock-ticks you could limit the branches on which a test-integration run is triggered.
Before we had:
on:
pull_request:
push:
branches: [master, develop]
That might be slightly better from running on every push.
There was a problem hiding this comment.
I reverted it back to how it was.
| run: composer test | ||
| - name: Output log files on failure | ||
| if: failure() | ||
| run: cd ci/docker && docker-compose exec -T php-fpm.stepup.example.com cat var/log/webtest.log |
There was a problem hiding this comment.
Have you tested an error situation? I highly doubt this line will work :)
Feel free to fix this on your next PR 💪
VadimSchmitz
force-pushed
the
feature/travis-to-gha
branch
12 times, most recently
from
e646a1e to
e6466e0
Compare
The following test-integration workflow will start up the container using the docker-composer file. afterwards it will do some installation and then run the tests. Also fixed typo in file name of docker-compose
VadimSchmitz
force-pushed
the
feature/travis-to-gha
branch
from
e6466e0 to
b35d5cf
Compare
| run: composer test | ||
| - name: Output log files on failure | ||
| if: failure() | ||
| run: cd ci/docker && docker-compose exec -T ra-test cat var/log/error.log |
There was a problem hiding this comment.
Okay with me to leave this like this for now.
In this pullrequest a docker-compose file has been added for the testing of code on a container.
The github action workflow has been configured and passes the tests.