Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix TypeError #73

Merged
merged 1 commit into from
Oct 31, 2024
Merged

Fix TypeError #73

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 0 additions & 5 deletions ci/qa/phpstan-baseline.neon
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -285,11 +285,6 @@ parameters:
count: 1
path: ../../src/OpenConext/UserLifecycle/Infrastructure/UserLifecycleBundle/Command/InformationCommand.php

-
message: "#^Parameter \\#1 \\$collection of method OpenConext\\\\UserLifecycle\\\\Domain\\\\Service\\\\SummaryServiceInterface\\:\\:summarizeInformationResponse\\(\\) expects OpenConext\\\\UserLifecycle\\\\Domain\\\\Client\\\\InformationResponseCollectionInterface, OpenConext\\\\UserLifecycle\\\\Domain\\\\Client\\\\InformationResponseInterface given\\.$#"
count: 1
path: ../../src/OpenConext/UserLifecycle/Infrastructure/UserLifecycleBundle/Command/InformationCommand.php

-
message: "#^Parameter \\#1 \\$messages of method Symfony\\\\Component\\\\Console\\\\Output\\\\OutputInterface\\:\\:write\\(\\) expects iterable\\<string\\>\\|string, string\\|false given\\.$#"
count: 1
Expand Down
3 changes: 2 additions & 1 deletion src/OpenConext/UserLifecycle/Application/QueryHandler/FindUserInformationQueryHandler.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@
namespace OpenConext\UserLifecycle\Application\QueryHandler;

use OpenConext\UserLifecycle\Application\Query\FindUserInformationQuery;
use OpenConext\UserLifecycle\Domain\Client\InformationResponseCollectionInterface;
use OpenConext\UserLifecycle\Domain\Client\InformationResponseInterface;
use OpenConext\UserLifecycle\Domain\Service\InformationServiceInterface;

Expand All @@ -33,7 +34,7 @@ public function __construct(

public function handle(
FindUserInformationQuery $query,
): InformationResponseInterface {
): InformationResponseCollectionInterface {
return $this->informationService->readInformationFor($query->getCollabPersonId());
}
}
3 changes: 2 additions & 1 deletion ...onext/UserLifecycle/Application/QueryHandler/FindUserInformationQueryHandlerInterface.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,11 +21,12 @@
namespace OpenConext\UserLifecycle\Application\QueryHandler;

use OpenConext\UserLifecycle\Application\Query\FindUserInformationQuery;
use OpenConext\UserLifecycle\Domain\Client\InformationResponseCollectionInterface;
use OpenConext\UserLifecycle\Domain\Client\InformationResponseInterface;

interface FindUserInformationQueryHandlerInterface
{
public function handle(
FindUserInformationQuery $query,
): InformationResponseInterface;
): InformationResponseCollectionInterface;
}
7 changes: 2 additions & 5 deletions src/OpenConext/UserLifecycle/Domain/Service/InformationServiceInterface.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,14 +20,11 @@

namespace OpenConext\UserLifecycle\Domain\Service;

use OpenConext\UserLifecycle\Domain\Client\InformationResponseInterface;
use OpenConext\UserLifecycle\Domain\Client\InformationResponseCollectionInterface;

interface InformationServiceInterface
{
/**
* @return InformationResponseInterface
*/
public function readInformationFor(
string $personId,
);
): InformationResponseCollectionInterface;
}