Docker: Log to json, fixes multiline logging in Docker #1337
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is the information added by the AdditionalInfoFormatter also preserved in the JSON? |
quartje
force-pushed
the
feature/docker_json_logging
branch
from
dd7e67b to
b855f04
Compare
thijskh
approved these changes
Nov 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since Docker logs to stdout, the ident to distinguish between the authentication and application logs is no longer applicable.
Furthermore, logging using the regular formatters lead to all logs landing in a single line, making it hard to read and distinguish. It also hits the 16KB logline length of Docker
Using the syslog formatter fixes those issues.