Skip to content
This repository has been archived by the owner on Jun 12, 2024. It is now read-only.

Bugfix IE11, known issue with flex-direction: column #24

Closed
wants to merge 1 commit into from

Conversation

rooney
Copy link

@rooney rooney commented Feb 29, 2016

@MartijnR
Copy link

That looks exciting! Will check it out.

❌ small form OC theme: not stretching to bottom of window (minor?)
loading screen very small - is same as previous issue (minor?), this issue can be reduced by adding to _iefix.scss:

.form__loader {
        min-height: 200px;
}

✅ grid theme
❌ analog pickers not stretching to maximum height (minor, I think)
✅ check if MS Edge also captured by media
✅ long form, not in pages mode
✅ different screensizes, responsive to small widths?
✅ ] add ?touch=true to simulate touchscreen
✅ print style
✅ : form in pages mode
❌ side slider stretching to bottom (check long form): not stretching to bottom (major)
✅ rtl

before merging:

  • add form__loader 'fix' from above
  • add comment to readme.md about IE11 support: Draft records and editing of existing records does not work in IE11. Slightly degraded styling in IE11 is considered acceptable.
  • remove require('./module/redirect-IE') from public/js/src/main-webform.js

@MartijnR
Copy link

@kkrumlian @rooney @sdibona Found issues 1, 2, 3 and 4. See above (incl workaround to make 2 less serious) and screenshots below in order. If you consider issues 1, 2 and 3 (which probably all have the same cause - broken flex stretching) as an acceptable degraded experience for IE11 only, then only issue 4 would need to be resolved. Issue 4 seems important to me because if the users scrolls to the bottom of a long form and clicks the side slider handle, the user probably won't be able to find the side slider.

screen shot 2016-02-29 at 2 45 38 pm

screen shot 2016-02-29 at 2 50 56 pm

screen shot 2016-02-29 at 3 07 23 pm

screen shot 2016-02-29 at 2 40 12 pm

@MartijnR MartijnR mentioned this pull request Feb 29, 2016
@rooney
Copy link
Author

rooney commented Mar 7, 2016

@kkrumlian @MartijnR

Fahri has revised his commit to address Martijn's feedback

@MartijnR
Copy link

MartijnR commented Mar 7, 2016

Confirmed that this fixes issue 4! 👍

I've added a few little things (workaround for issue 2) and stuffed it all in branch fix/IE-styling-2 (off-master, doesn't include iOS fixes). 4a4b09a

@kkrumlian Just tell me if you want me to merge this.

@kkrumlian
Copy link

@MartijnR Yes please let's merge it.

@MartijnR
Copy link

MartijnR commented Mar 7, 2016

Done! (note the iOS fixes are not merged yet, pending any tests by OC. I have merged and reorganized them in kobotoolbox/enketo-express already.)

@MartijnR MartijnR closed this Mar 7, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants