Fixed Gaussian curve Peak Transfer overfitting #574
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eselmeister
reviewed
Dec 3, 2024
....supplier.templates/src/net/openchrom/xxd/process/supplier/templates/peaks/PeakTransfer.java
Outdated
Show resolved
Hide resolved
eselmeister
reviewed
Dec 3, 2024
....supplier.templates/src/net/openchrom/xxd/process/supplier/templates/peaks/PeakTransfer.java
Outdated
Show resolved
Hide resolved
|
Don't forget to put yourself in the header. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#556 already improved the situation because it adjusts the narrowness of the curves, but we can do better by trimming sigma even further until it fits under the total signal. This optimization function takes some time, so I added a progress monitor. Step size is also optimized for speed and could be reduced for better fits, but it didn't matter too much in my test data.