Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added a mass spectra hash (splash) converter #107

Merged
merged 1 commit into from
Jan 20, 2022

Conversation

Mailaender
Copy link
Member

This is using @berlinguyinca's Java reference implementation. So far, I have not managed to get a hit on @MassBank even when querying their database entries loaded into OpenChrom. Some distortion seems to take place that I am unaware of. Another caveat is that it is quite hidden and requires exporting into files instead of just copying it to the clipboard so there is room for future improvement.

Closes eclipse/chemclipse#567. Depends on OpenChrom/openchrom3rdpl#11.

@Mailaender Mailaender force-pushed the splash branch 2 times, most recently from 949b2e9 to 4be538e Compare January 17, 2022 09:57
@eselmeister
Copy link
Contributor

The CI is failing. Could you have a look at that issue?

@Mailaender
Copy link
Member Author

This is fixed now.

@eselmeister eselmeister merged commit b00c9cc into OpenChrom:develop Jan 20, 2022
@Mailaender Mailaender deleted the splash branch January 20, 2022 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Splash (Spectra Hash) support
2 participants