feat: support sepolia testnet #61
Conversation
✅ Deploy Preview for new-admin-opencerts ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
This reverts commit aa3bccc.
src/app.tsx
Outdated
| if (e instanceof EthereumProviderError) { | ||
| e.code === 4001 ? setMetamaskConnected(true) : console.debug(e); | ||
| } |
There was a problem hiding this comment.
Shall we also put an else to handle when e is not an instance of EthereumProviderError?
There was a problem hiding this comment.
Good catch! Ill update it!
Actually, Ill also change the other error handling to log ? log(e.message) : console.error(e.message) instead of
admin-website-v2/src/components/util/issue.tsx
Lines 22 to 24 in a9146e7
log object is undefined
There was a problem hiding this comment.
Yes, that would be good as well to default to console.error(e.message)
When e is not an instance of Error, maybe we can do this:
log ? log("Unable to issue certificate", e) : console.error("Unable to issue certificate", e);
// or
log ? log("Unable to issue certificate", JSON.stringify(e)) : console.error("Unable to issue certificate", JSON.stringify(e));
integration/metamask-init.mjs
Outdated
| const addNetworkPromise = dappPage.evaluate(addNetwork); | ||
| try { | ||
| setTimeout(async () => { | ||
| await metamask.acceptAddNetwork(true); | ||
| }, 2000); | ||
| } catch (e) { | ||
| // ignore error | ||
| } | ||
|
|
||
| await addNetworkPromise; |
There was a problem hiding this comment.
Not too sure about this section. Should we be using await sleep(2000) instead of setTimeout()?
Furthermore, the last line can be:
await dappPage.evaluate(addNetwork);There was a problem hiding this comment.
Somehow, if I add the await, it won't work... 🤔
Ill either have to separate the code (like the Dappeteer testcase) or just call dappPage.evaluate(addNetwork) before await metamask.acceptAddNetwork(true);
Anyway I removed the setTimeout from the code await metamask.acceptAddNetwork(true); as its no longer needed
There was a problem hiding this comment.
FYI about what the 2 code does,
dappPage.evaluate(addNetwork) opens a page to add the new network as per our configuration
metamask.acceptAddNetwork(true) will supposedly click on the button "Approve" to add the new network, and then do a switch of network to the new network (reference)
Context
unknownnetwork when metamask wallet is set toSepoliabecause it is not supported (Add Sepolia to InfuraProvider ethers-io/ethers.js#3325)What this PR does
Sepoliatestnet can be supportedintegration:waiteth-rpc-errorsas recommended by metamaskEthereumProviderErrorinstead ofEthereumRpcErrorbecause we are previously checking for code 4001 which is inEIP-1193(for context of code 4001 returned by metamask, visit https://eips.ethereum.org/EIPS/eip-1193#provider-errors)page.waitForchanged to use custom timeoutsleep(can't use waitForTimeout because its obsolete)Localhost 8545testnetnpm run dev