Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[frontend/backend] Remove authorized members action on Restricted entities view - chunk 2 #9312

Open
wants to merge 1 commit into
base: release/6.5.0
Choose a base branch
from

Conversation

CelineSebe
Copy link
Member

@CelineSebe CelineSebe commented Dec 12, 2024

Proposed changes

  • Fix organization sharing enable/disable
  • Implemented remove authorized_members action in the dataTableToolbar
  • Implemented tests

Related issues

Checklist

  • I consider the submitted work as finished
  • I tested the code for its functionality
  • I wrote test cases for the relevant uses case (coverage and e2e)
  • I added/update the relevant documentation (either on github or on notion)
  • Where necessary I refactored code to improve the overall quality

Further comments

@github-actions github-actions bot added the filigran team use to identify PR from the Filigran team label Dec 12, 2024
Copy link

codecov bot commented Dec 12, 2024

Codecov Report

Attention: Patch coverage is 89.47368% with 2 lines in your changes missing coverage. Please review.

Project coverage is 65.39%. Comparing base (537ff33) to head (1165b22).

Files with missing lines Patch % Lines
...latform/opencti-graphql/src/manager/taskManager.js 81.81% 2 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff               @@
##           release/6.5.0    #9312   +/-   ##
==============================================
  Coverage          65.38%   65.39%           
==============================================
  Files                626      626           
  Lines              60127    60145   +18     
  Branches            6767     6774    +7     
==============================================
+ Hits               39313    39330   +17     
- Misses             20814    20815    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@CelineSebe CelineSebe changed the base branch from master to release/6.5.0 December 16, 2024 13:28
@marieflorescontact marieflorescontact force-pushed the issue/4961-chunk2 branch 2 times, most recently from 5aa6ebf to cde8e00 Compare December 17, 2024 14:07
@CelineSebe CelineSebe changed the title [frontend/backend] Screen panel for restricted entites - chunk 2 [frontend/backend] Remove authorized members action on Restricted entities view - chunk 2 Dec 18, 2024
@CelineSebe CelineSebe marked this pull request as ready for review December 18, 2024 10:25
@@ -202,7 +203,7 @@ const Management = () => {
<div style={{ paddingRight: isRightMenuManagementEnable ? '200px' : 0 }}>
<Breadcrumbs elements={[
{ label: t_i18n('Data') },
{ label: t_i18n('Management') },
{ label: t_i18n('Restriction') },
Copy link
Member

@SouadHadjiat SouadHadjiat Dec 18, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so we changed "Management" to "Restriction" ? is it confirmed with product @nino-filigran ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

validated by @nino-filigran 👌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
filigran team use to identify PR from the Filigran team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants