[frontend/backend] New user shouldn't be assigned default groups if other groups are specified (#9234)

[Archidoit]

Proposed changes

• In User creation form, in Group list field, groups should be ordered alphabetically
• [backend] When creating a user, if groups are specified, don't add also the user to the default groups (only add the user to the default groups if no groups are specified)
• In the front, in user creation form, the groups initial values are the default groups

Related issues

#9273
#9234

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 65.38%. Comparing base (0a4409d) to head (321f63f).
Report is 1 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #9274      +/-   ##
==========================================
+ Coverage   65.37%   65.38%   +0.01%     
==========================================
  Files         624      624              
  Lines       59660    59663       +3     
  Branches     6686     6687       +1     
==========================================
+ Hits        39000    39010      +10     
+ Misses      20660    20653       -7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[lndrtrbn]

Now that default groups are set in the form in the UI I don't think we should check on the backend if nothing is set then set the defaults. Because, in my opinion, as a user if I clear the field with the defaults, it's not to see the user created with defaults anyway after all.

Would be nice to have product opinion

[Archidoit]

Now that default groups are set in the form in the UI I don't think we should check on the backend if nothing is set then set the defaults. Because, in my opinion, as a user if I clear the field with the defaults, it's not to see the user created with defaults anyway after all.

Would be nice to have product opinion

It was in case users are created from the API... If no groups are specified, the user should be added to the default groups (we don't create users with no groups). @nino-filigran @romain-filigran What do you think?

[nino-filigran]

I agree that we need to also have a check at BE side in case you create through API only. Your comment makes sense @Archidoit

[SouadHadjiat]

could you update user-test to test these changes ? There is at least the part "User has no capability query behavior" that removes the default_assignation, which is not necessary anymore. And maybe add a test to make sure when we create a user with a specific group, we don't assign the default group to the user.

[Archidoit]

could you update user-test to test these changes ? There is at least the part "User has no capability query behavior" that removes the default_assignation, which is not necessary anymore. And maybe add a test to make sure when we create a user with a specific group, we don't assign the default group to the user.

@SouadHadjiat I don't understand why you want we to remove the default_assignation of 'User has no capability query behavior'. If so, the user will be affected to the default group since there are no groups specified in the user to create input.

[Archidoit]

@SouadHadjiat tests written :)

[Archidoit]

Waiting for Product decision about the functional breaking change (@romain-filigran )