Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[frontend/backend] Specify arch and platform when creating injects for OpenBAS (#8820) #9250

Draft
wants to merge 54 commits into
base: master
Choose a base branch
from

Conversation

savacano28
Copy link

@savacano28 savacano28 commented Dec 5, 2024

Proposed changes

  • Refactor form StixCoreObjectSimulationResult to add platforms and arch, and some behavior related to AI option.
  • Add placeholder for ttps not covered from obas.

Docs

Related issues

Checklist

  • I consider the submitted work as finished
  • I tested the code for its functionality
  • I wrote test cases for the relevant uses case (coverage and e2e)
  • I added/update the relevant documentation (either on github or on notion)
  • Where necessary I refactored code to improve the overall quality

Further comments

@savacano28 savacano28 added the filigran team use to identify PR from the Filigran team label Dec 5, 2024
@savacano28 savacano28 self-assigned this Dec 5, 2024
@savacano28 savacano28 changed the title [frontend/backend] wip [frontend/backend] Specify arch and platform when creating injects for OpenBAS (#8820) Dec 5, 2024
@savacano28 savacano28 force-pushed the issue/8820 branch 4 times, most recently from 3f41956 to 7ee2dc3 Compare December 10, 2024 14:39
Copy link

codecov bot commented Dec 10, 2024

Codecov Report

Attention: Patch coverage is 1.63934% with 120 lines in your changes missing coverage. Please review.

Project coverage is 65.30%. Comparing base (ad6edc8) to head (0e73754).
Report is 4 commits behind head on master.

Files with missing lines Patch % Lines
...form/opencti-graphql/src/modules/xtm/xtm-domain.js 1.25% 79 Missing ⚠️
...-platform/opencti-graphql/src/database/xtm-obas.ts 2.38% 41 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #9250      +/-   ##
==========================================
- Coverage   65.31%   65.30%   -0.01%     
==========================================
  Files         624      624              
  Lines       59655    59728      +73     
  Branches     6669     6684      +15     
==========================================
+ Hits        38963    39008      +45     
- Misses      20692    20720      +28     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@savacano28 savacano28 marked this pull request as ready for review December 10, 2024 16:42
@savacano28 savacano28 marked this pull request as draft December 11, 2024 10:57
@savacano28 savacano28 requested a review from Archidoit December 12, 2024 11:52
@savacano28 savacano28 marked this pull request as ready for review December 12, 2024 11:52
@RomuDeuxfois
Copy link
Member

A new release has been done on OpenSide with the first step of this feature.
https://github.com/OpenBAS-Platform/openbas/releases/tag/1.10.1

So this PR can be merge when it's ready.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
filigran team use to identify PR from the Filigran team
Projects
None yet
3 participants