-
Notifications
You must be signed in to change notification settings - Fork 972
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[backend] add validation mode to askJobImport (#6728) #9249
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## release/6.5.0 #9249 +/- ##
=================================================
+ Coverage 65.21% 66.05% +0.83%
=================================================
Files 626 626
Lines 59892 60366 +474
Branches 6688 7386 +698
=================================================
+ Hits 39059 39873 +814
+ Misses 20833 20493 -340 ☔ View full report in Codecov by Sentry. |
251c0ca
to
cbbfe14
Compare
ba68399
to
d1878c6
Compare
@@ -8625,7 +8625,7 @@ type Mutation { | |||
deleteImport(fileName: String): ID | |||
uploadImport(file: Upload!, fileMarkings: [String]): File | |||
uploadPending(file: Upload!, entityId: String, labels: [String], errorOnExisting: Boolean, refreshEntity: Boolean): File | |||
askJobImport(fileName: ID!, connectorId: String, configuration: String, bypassEntityId: String, bypassValidation: Boolean): File | |||
askJobImport(fileName: ID!, connectorId: String, configuration: String, bypassEntityId: String, bypassValidation: Boolean, validationMode: String): File |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm wondering if we shouldn't have an enum here instead of String ? so it can either be workbench or draft, not any string.
Proposed changes
Related issues
Checklist
Further comments