Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[backend/frontend] Management panel for restricted entities - chunk1 (#4961) #9219

Merged
merged 7 commits into from
Dec 17, 2024
Merged

[backend/frontend] Management panel for restricted entities - chunk1 (#4961) #9219

merged 7 commits into from
Dec 17, 2024

Conversation

marieflorescontact
Copy link
Member

@marieflorescontact marieflorescontact commented Dec 3, 2024 •
edited by CelineSebe
Loading

Proposed changes

  • Add stixCoreObjectsRestricted api to list all restricted entities (for BYPASS user only) + tests (+ 2 create + 2 update + 2 delete)
  • Add Data > Management > Restricted entites root
  • Add DataTable screen to list restricted entities
  • Add explanation card
  • Add FF for the menus

Related issues

Checklist

  • I consider the submitted work as finished
  • I tested the code for its functionality
  • I wrote test cases for the relevant uses case (coverage and e2e)
  • I added/update the relevant documentation (either on github or on notion)
  • Where necessary I refactored code to improve the overall quality

Further comments

@marieflorescontact marieflorescontact changed the title [backend] List all restricted Stix Core Objects [backend/front] Screen panel for restricted entities: chunk 1 Dec 3, 2024
@codecov Codecov
Copy link

codecov bot commented Dec 3, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 40.74074% with 16 lines in your changes missing coverage. Please review.

Project coverage is 65.26%. Comparing base (04858e8) to head (1e4213f).
Report is 4 commits behind head on release/6.5.0.

Files with missing lines Patch % Lines
...tform/opencti-graphql/src/domain/stixCoreObject.js 38.46% 16 Missing ⚠️
Additional details and impacted files 
@@              Coverage Diff               @@
##           release/6.5.0    #9219   +/-   ##
==============================================
  Coverage          65.26%   65.26%           
==============================================
  Files                626      626           
  Lines              59974    59968    -6     
  Branches            6716     6714    -2     
==============================================
- Hits               39141    39139    -2     
+ Misses             20833    20829    -4

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@labo-flg labo-flg added the filigran team use to identify PR from the Filigran team label Dec 6, 2024
@marieflorescontact marieflorescontact force-pushed the issue/4961 branch 4 times, most recently from f80b960 to e4a4095 Compare December 11, 2024 14:43
@CelineSebe CelineSebe marked this pull request as ready for review December 11, 2024 16:16
@CelineSebe CelineSebe linked an issue Dec 11, 2024 that may be closed by this pull request
Authorized members on Containers: Remove Feature Flag & Verify testing coverage #8943
Open
@CelineSebe CelineSebe removed a link to an issue Dec 11, 2024
Authorized members on Containers: Remove Feature Flag & Verify testing coverage #8943
Open
@delemaf delemaf self-requested a review December 12, 2024 17:12
delemaf
delemaf reviewed Dec 13, 2024
View reviewed changes
Copy link
Member

@delemaf delemaf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested functionally 🚀 Just few little code suggestion

opencti-platform/opencti-front/src/components/dataGrid/DataTable.tsx Outdated Show resolved Hide resolved
opencti-platform/opencti-front/src/private/components/data/Management.tsx Outdated Show resolved Hide resolved
aHenryJard
aHenryJard requested changes Dec 13, 2024
View reviewed changes
Copy link
Member

@aHenryJard aHenryJard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The data management menu on the left is displayed without feature flag, so I'm blocking for now.

@CelineSebe
Copy link
Member

All comments are resolved. Waiting for approval.

@SouadHadjiat SouadHadjiat changed the title [backend/front] Screen panel for restricted entities: chunk 1 [backend/frontend] Screen panel for restricted entities: chunk 1 Dec 16, 2024
@SouadHadjiat SouadHadjiat changed the title [backend/frontend] Screen panel for restricted entities: chunk 1 [backend/frontend] Management panel for restricted entities - chunk1 (#4961) Dec 16, 2024
aHenryJard
aHenryJard approved these changes Dec 17, 2024
View reviewed changes
Copy link
Member

@aHenryJard aHenryJard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removing the change request

@CelineSebe CelineSebe merged commit eba5e50 into release/6.5.0 Dec 17, 2024
5 checks passed
@CelineSebe CelineSebe deleted the issue/4961 branch December 17, 2024 09:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@delemaf delemaf delemaf left review comments

@aHenryJard aHenryJard aHenryJard approved these changes

@SouadHadjiat SouadHadjiat SouadHadjiat approved these changes

Assignees

@marieflorescontact marieflorescontact

@CelineSebe CelineSebe

Labels
filigran team use to identify PR from the Filigran team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@marieflorescontact @CelineSebe @SouadHadjiat @aHenryJard @delemaf @labo-flg