Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[backend] check playbook filters & add playbook nodes tests (#8721) #8955

Merged
merged 5 commits into from
Nov 14, 2024

Conversation

Archidoit
Copy link
Member

Proposed changes

Modify the playbook filters checking done in backend at playbook node adding/replacement.

Related issues

#8721

@Archidoit Archidoit added the filigran team use to identify PR from the Filigran team label Nov 8, 2024
@Archidoit Archidoit self-assigned this Nov 8, 2024
Copy link

codecov bot commented Nov 8, 2024

Codecov Report

Attention: Patch coverage is 28.00000% with 18 lines in your changes missing coverage. Please review.

Project coverage is 66.28%. Comparing base (0dc1991) to head (a09c290).
Report is 3 commits behind head on master.

Files with missing lines Patch % Lines
...ti-graphql/src/modules/playbook/playbook-domain.ts 19.04% 17 Missing ⚠️
...orm/opencti-graphql/src/manager/playbookManager.ts 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8955      +/-   ##
==========================================
- Coverage   66.28%   66.28%   -0.01%     
==========================================
  Files         597      597              
  Lines       61098    61105       +7     
  Branches     6288     6292       +4     
==========================================
+ Hits        40501    40505       +4     
- Misses      20597    20600       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Archidoit Archidoit changed the title [backend] check and build playbook filters (#8721) [backend] check playbook filters (#8721) Nov 8, 2024
@SouadHadjiat
Copy link
Member

would it be possible to add a test for this bug fix ? a playbook-test is now available on master with resolver tests that can be completed.

@Archidoit Archidoit changed the title [backend] check playbook filters (#8721) [backend] check playbook filters & playbook nodes tests (#8721) Nov 12, 2024
@Archidoit Archidoit changed the title [backend] check playbook filters & playbook nodes tests (#8721) [backend] check playbook filters & add playbook nodes tests (#8721) Nov 13, 2024
Copy link
Member

@lndrtrbn lndrtrbn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works fine, I restarted the CI, e2e were failing

@Archidoit Archidoit merged commit 28da644 into master Nov 14, 2024
6 checks passed
@Archidoit Archidoit deleted the issue/8721 branch November 14, 2024 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
filigran team use to identify PR from the Filigran team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Playbooks] unable to filter on "Platform Creation Date" on "Query knowledge on regular basis"
3 participants