-
Notifications
You must be signed in to change notification settings - Fork 961
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[backend] check playbook filters & add playbook nodes tests (#8721) #8955
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #8955 +/- ##
==========================================
- Coverage 66.28% 66.28% -0.01%
==========================================
Files 597 597
Lines 61098 61105 +7
Branches 6288 6292 +4
==========================================
+ Hits 40501 40505 +4
- Misses 20597 20600 +3 ☔ View full report in Codecov by Sentry. |
would it be possible to add a test for this bug fix ? a playbook-test is now available on master with resolver tests that can be completed. |
opencti-platform/opencti-graphql/src/modules/playbook/playbook-domain.ts
Show resolved
Hide resolved
d3fa1b9
to
0dd4cde
Compare
opencti-platform/opencti-graphql/tests/utils/testQueryHelper.ts
Outdated
Show resolved
Hide resolved
5050046
to
a09c290
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works fine, I restarted the CI, e2e were failing
Proposed changes
Modify the playbook filters checking done in backend at playbook node adding/replacement.
Related issues
#8721