Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[backend] add external ref files into AI summarize (#8413) #8926

Merged
merged 3 commits into from
Nov 14, 2024
Merged

Conversation

frapuks
Copy link
Member

@frapuks frapuks commented Nov 6, 2024

Proposed changes

  • add external ref files in AI summarize

Related issues

Checklist

  • I consider the submitted work as finished
  • I tested the code for its functionality
  • I wrote test cases for the relevant uses case (coverage and e2e)
  • I added/update the relevant documentation (either on github or on notion)
  • Where necessary I refactored code to improve the overall quality

@frapuks frapuks added the filigran team use to identify PR from the Filigran team label Nov 6, 2024
@frapuks frapuks self-assigned this Nov 6, 2024
@frapuks frapuks marked this pull request as draft November 6, 2024 14:53
Copy link

codecov bot commented Nov 7, 2024

Codecov Report

Attention: Patch coverage is 7.14286% with 13 lines in your changes missing coverage. Please review.

Project coverage is 66.63%. Comparing base (e083712) to head (c11c054).
Report is 24 commits behind head on master.

Files with missing lines Patch % Lines
...atform/opencti-graphql/src/modules/ai/ai-domain.ts 7.14% 13 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8926      +/-   ##
==========================================
+ Coverage   66.30%   66.63%   +0.32%     
==========================================
  Files         597      597              
  Lines       61033    61061      +28     
  Branches     6279     6592     +313     
==========================================
+ Hits        40468    40687     +219     
+ Misses      20565    20374     -191     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@frapuks frapuks marked this pull request as ready for review November 7, 2024 13:14
@frapuks frapuks added this to the Release 6.3.11 milestone Nov 7, 2024
Copy link
Member

@marieflorescontact marieflorescontact left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

locally tested ok 👌

@frapuks frapuks merged commit 69d4229 into master Nov 14, 2024
6 checks passed
@frapuks frapuks deleted the issue/8413 branch November 14, 2024 09:53
@SamuelHassine SamuelHassine removed this from the Release 6.3.12 milestone Nov 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
filigran team use to identify PR from the Filigran team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[AI] "Summaries file"on all files does not always work
4 participants