Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[frontend] Improve error message notification in the UI (#8923) #8924

Merged
merged 1 commit into from
Nov 8, 2024

Conversation

richard-julien
Copy link
Member

See #8923

@richard-julien richard-julien linked an issue Nov 6, 2024 that may be closed by this pull request
@github-actions github-actions bot added the filigran team use to identify PR from the Filigran team label Nov 6, 2024
Copy link

codecov bot commented Nov 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.30%. Comparing base (e083712) to head (16b2a55).
Report is 11 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8924      +/-   ##
==========================================
- Coverage   66.30%   66.30%   -0.01%     
==========================================
  Files         597      597              
  Lines       61033    61033              
  Branches     6279     6276       -3     
==========================================
- Hits        40468    40467       -1     
- Misses      20565    20566       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@frapuks frapuks self-requested a review November 8, 2024 08:37
Copy link
Member

@frapuks frapuks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It will also fix this open bug : #8186

@richard-julien richard-julien merged commit 0afc94b into master Nov 8, 2024
6 checks passed
@richard-julien richard-julien deleted the issue/8923 branch November 8, 2024 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
filigran team use to identify PR from the Filigran team
Projects
None yet
2 participants