Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[frontend] Extension is not always set to .json (#7720) #8746

Merged
merged 2 commits into from
Oct 28, 2024

Conversation

ValentinBouzinFiligran
Copy link
Member

Proposed changes

  • ".json" added at the end of the new file name
  • mime type removed

Related issues

Checklist

  • I consider the submitted work as finished
  • I tested the code for its functionality
  • I wrote test cases for the relevant uses case (coverage and e2e)
  • I added/update the relevant documentation (either on github or on notion)
  • Where necessary I refactored code to improve the overall quality

Further comments

@ValentinBouzinFiligran ValentinBouzinFiligran added the filigran team use to identify PR from the Filigran team label Oct 23, 2024
Copy link

codecov bot commented Oct 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.31%. Comparing base (7d60d33) to head (628daf0).
Report is 28 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8746      +/-   ##
==========================================
+ Coverage   66.29%   66.31%   +0.01%     
==========================================
  Files         597      597              
  Lines       60958    60958              
  Branches     6267     6266       -1     
==========================================
+ Hits        40414    40422       +8     
+ Misses      20544    20536       -8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ValentinBouzinFiligran
Copy link
Member Author

ValentinBouzinFiligran commented Oct 23, 2024

mime type removed to be simpler as written in the lib doc
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
filigran team use to identify PR from the Filigran team
Projects
None yet
2 participants