[backend] Fix missing entities in shared Report (#8333) #8366
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
filigran team
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #8366 +/- ##
==========================================
+ Coverage 66.18% 66.30% +0.11%
==========================================
Files 597 597
Lines 60392 60532 +140
Branches 6207 6323 +116
==========================================
+ Hits 39972 40133 +161
+ Misses 20420 20399 -21 ☔ View full report in Codecov by Sentry. |
marieflorescontact
force-pushed
the
issue/8333
branch
from
d1085f9
to
8d65d17
Compare
SamuelHassine
force-pushed
the
master
branch
from
f8359b7
to
558e6c1
Compare
marieflorescontact
force-pushed
the
issue/8333
branch
7 times, most recently
from
bdfc3a5
to
c88f56c
Compare
aHenryJard
force-pushed
the
issue/8333
branch
from
c88f56c
to
33f0c27
Compare
aHenryJard
reviewed
Sep 20, 2024
| @@ -401,7 +401,7 @@ const executeRuleElementRescan = async (context, user, actionContext, element) = | |||
| } | |||
| } | |||
| }; | |||
| const executeShare = async (context, user, actionContext, element) => { | |||
| export const executeShare = async (context, user, actionContext, element) => { | |||
aHenryJard
reviewed
Sep 20, 2024
| expect(organizationSharingQueryResult?.data?.stixCoreObjectEdit.restrictionOrganizationAdd.objectOrganization[0].name).toEqual(TEST_ORGANIZATION.name); | ||
|
|
||
| // Need background task magic to happens for sharing | ||
| await taskHandler(); |
There was a problem hiding this comment.
This is a kind of hack, not sure of this. But we will have some random issue if the manager has not run before next test. The alternative would be to do this test at domain level in taskManager-test, calling taskManager.executeShare.
marieflorescontact
force-pushed
the
issue/8333
branch
5 times, most recently
from
9bad91d
to
5c0c5e2
Compare
marieflorescontact
force-pushed
the
issue/8333
branch
from
5c0c5e2
to
eef416b
Compare
marieflorescontact
force-pushed
the
issue/8333
branch
from
f9bc7e9
to
0235ea3
Compare
marieflorescontact
force-pushed
the
issue/8333
branch
from
0235ea3
to
661db60
Compare
SouadHadjiat
reviewed
Oct 3, 2024
| @@ -67,7 +67,7 @@ schemaRelationsRefDefinition.registerRelationsRef(ENTITY_TYPE_CONTAINER_GROUPING | |||
| schemaRelationsRefDefinition.registerRelationsRef(ENTITY_TYPE_VULNERABILITY, [objectOrganization]); | |||
|
|
|||
| schemaRelationsRefDefinition.registerRelationsRef(ENTITY_TYPE_IDENTITY_SYSTEM, [objectOrganization]); | |||
| schemaRelationsRefDefinition.registerRelationsRef(ENTITY_TYPE_IDENTITY_SECTOR, []); | |||
| schemaRelationsRefDefinition.registerRelationsRef(ENTITY_TYPE_IDENTITY_SECTOR, [objectOrganization]); | |||
There was a problem hiding this comment.
Sectors shouldn't have organization restriction (part of unrestricted entities)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
SystemandIndividualin STIX_ORGANIZATIONS_UNRESTRICTEDRelated issues
Checklist
Further comments