Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Regression in massive operations on data tables #8571

Closed
SamuelHassine opened this issue Oct 2, 2024 · 5 comments · Fixed by #8796
Closed

Regression in massive operations on data tables #8571

SamuelHassine opened this issue Oct 2, 2024 · 5 comments · Fixed by #8796
Assignees
@lndrtrbn
Labels
bug use for describing something not working as expected regression Label to identify the bug as a regression of previously working feature solved use to identify issue that has been solved (must be linked to the solving PR)
Milestone
Release 6.3.11

Comments

@SamuelHassine
Copy link
Member

Description

  1. Go to Data => Entities
  2. Search for something
  3. Select one element with a checkbox
  4. Change the keyword and search for something else
  5. Select another element

=> Previous behaviour: 2 elements selected

=> Current behaviour: onlye the last element is selected, 1 selected element

This regression is preventing users to correctly merge entities after multiple search / filters.
@SamuelHassine SamuelHassine added bug use for describing something not working as expected needs triage use to identify issue needing triage from Filigran Product team regression Label to identify the bug as a regression of previously working feature labels Oct 2, 2024
@nino-filigran nino-filigran added needs more info Intel needed about the use case and removed needs triage use to identify issue needing triage from Filigran Product team labels Oct 3, 2024
@nino-filigran
Copy link

More info regarding how to display it.

@nino-filigran
Copy link

nino-filigran commented Oct 3, 2024 •
edited
Loading

After dicussion:

  • fix is to keep the selection even though the search/filter is trigggered (back to previous behavior)
  • indication in the "selected" the amount of selected elements to make the user understand this behavior (enhancement)

We're going to prioritze this bug.

@nino-filigran nino-filigran removed the needs more info Intel needed about the use case label Oct 3, 2024
@nino-filigran nino-filigran added this to the Bugs backlog milestone Oct 3, 2024
@lndrtrbn lndrtrbn self-assigned this Oct 23, 2024
@lndrtrbn
Copy link
Member

What I can see is that elements are still selected but the selection is not displayed on the table.
image
image

@nino-filigran
Copy link

nino-filigran commented Oct 23, 2024 •
edited
Loading

I don't have this behavior on demo.octi @lndrtrbn

selection.mp4

@lndrtrbn
Copy link
Member

Indeed, it seems we have multiple issues here. Try using the search, not filters

@lndrtrbn lndrtrbn mentioned this issue Oct 25, 2024
Merged
5 tasks
@lndrtrbn lndrtrbn linked a pull request Nov 6, 2024 that will close this issue
[frontend] Fix data tables interactions between selected elements and filters (#8571) #8796
Merged
5 tasks
lndrtrbn added a commit that referenced this issue Nov 6, 2024
@lndrtrbn
[frontend] Fix data tables interactions between selected elements and…
e0b95aa 
… filters (#8571)
@SamuelHassine SamuelHassine added the solved use to identify issue that has been solved (must be linked to the solving PR) label Nov 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lndrtrbn lndrtrbn

Labels
bug use for describing something not working as expected regression Label to identify the bug as a regression of previously working feature solved use to identify issue that has been solved (must be linked to the solving PR)
Projects
None yet
Milestone
Release 6.3.11
3 participants
@SamuelHassine @lndrtrbn @nino-filigran