Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CIRCLECI] Dynamic-CI 💡 #3328

Merged
merged 124 commits into from
Jan 31, 2025
Merged

Conversation

Renizmy
Copy link
Contributor

@Renizmy Renizmy commented Jan 21, 2025

Proposed changes

The main idea is to dynamically generate a ci configuration file at runtime based on the directory structure to facilitate building all containers.

  • Divide all container construction work into single units
  • Remove the need to manually add the build of new images
  • Add capability to build ARM images
  • Add capability to overload tags

Related issues

Checklist

Should not be merge yet, need to:

  • Adapt notify jobs

🚨 Some containers could be renamed (internal-export-file / internal-import-file)


  • I consider the submitted work as finished
  • I tested the code for its functionality using different use cases
  • I added/update the relevant documentation (either on github or on notion)
  • Where necessary I refactored code to improve the overall quality

@helene-nguyen helene-nguyen added the filigran team use to identify PR from the Filigran team label Jan 30, 2025
Copy link
Contributor

@flavienSindou flavienSindou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor remarks but this looks good to me. Thank you for this great work !

.circleci/vars.yml Show resolved Hide resolved
.circleci/scripts/generate_ci.py Show resolved Hide resolved
.circleci/scripts/generate_ci.py Show resolved Hide resolved
.circleci/scripts/generate_ci.py Show resolved Hide resolved
.circleci/scripts/generate_ci.py Outdated Show resolved Hide resolved
@helene-nguyen helene-nguyen merged commit a52bc90 into OpenCTI-Platform:master Jan 31, 2025
4 checks passed
@helene-nguyen helene-nguyen deleted the ci/dynamic-ci branch January 31, 2025 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
filigran team use to identify PR from the Filigran team
Projects
None yet
3 participants