Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Recorded Future] Handle properly playbook alerts errors to not block the connector #3213

Merged
merged 3 commits into from
Jan 8, 2025

Conversation

helene-nguyen
Copy link
Member

@helene-nguyen helene-nguyen commented Jan 3, 2025

Proposed changes

  • Handle properly playbook alerts errors to not block the connector
  • Remove assertions and replace with if/else condition for non-blocking solution to catch the error
  • Change TLP values to have default RED
  • Complete documentation
  • Remove unused methods

Related issues

Checklist

  • I consider the submitted work as finished
  • I tested the code for its functionality using different use cases
  • I added/update the relevant documentation (either on github or on notion)
  • Where necessary I refactored code to improve the overall quality

Further comments

Copy link
Contributor

@flavienSindou flavienSindou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the great work.

I made minor comments and suggestions but nothing blocking in my opinion.

external-import/recorded-future/README.md Show resolved Hide resolved
Comment on lines 45 to 48

if not self.rf_token:
raise ValueError("Recorded Future token is missing")

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this runtime data validation .

I think that get_config_variable already has this option thanks to the arg required=True

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes have been added, thanks @flavienSindou :)

external-import/recorded-future/src/rflib/pyrf.py Outdated Show resolved Hide resolved
@helene-nguyen helene-nguyen merged commit 073c463 into master Jan 8, 2025
4 checks passed
@helene-nguyen helene-nguyen deleted the bug/3195-rf branch January 8, 2025 06:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
filigran team use to identify PR from the Filigran team
Projects
None yet
2 participants