-
Notifications
You must be signed in to change notification settings - Fork 439
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Zvelo] Create a connector to download Zvelo intel #3121
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @romain-filigran, please find my feedback after some tests:
Once these errors are fixed:
✅ connector's workflow is clear
✅ README is crystal clear too
✅ no errors during ingestion
400 Bad Request
for 'phish' collection only (see logs below - idk if it's intended)
Note that not all my comments need to be addressed, only the ones with warnings (
Last but not least, I didn't write a specific comment about docstrings but can you fill/write them all please? 😇 I think this connector could benefit from later refactos and this type of comments could really help us to navigate through the code. It would be even better if you could also add some basic typing 🤩
Many thanks!
400 Bad Request logs:
connector-zvelo-1 | {"timestamp": "2024-12-17T19:01:36.327422Z", "level": "ERROR", "name": "Zvelo", "message": "[API] Error while fetching data in collection 'phish': ", "exc_info": "Traceback (most recent call last):\n File \"/opt/opencti-connector-zvelo/zvelo_connector/client_api.py\", line 78, in get_collections_entities\n response.raise_for_status()\n File \"/usr/local/lib/python3.12/site-packages/requests/models.py\", line 1024, in raise_for_status\n raise HTTPError(http_error_msg, response=self)\nrequests.exceptions.HTTPError: 400 Client Error: Bad Request for url: https://api.zvelo.io/v1/phish?page=0&created_date_start=2024-12-17T18%3A00%3A41.047713%2B00%3A00\n\nDuring handling of the above exception, another exception occurred:\n\nTraceback (most recent call last):\n File \"/opt/opencti-connector-zvelo/zvelo_connector/connector.py\", line 162, in process_message\n stix_objects = self._collect_intelligence(from_date=last_run)\n ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^\n File \"/opt/opencti-connector-zvelo/zvelo_connector/connector.py\", line 92, in _collect_intelligence\n entities = self.client.get_collections_entities(\n ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^\n File \"/opt/opencti-connector-zvelo/zvelo_connector/client_api.py\", line 93, in get_collections_entities\n raise Exception(error_msg)\nException: [API] Error while fetching data in collection 'phish': ", "taskName": null}
avoid Stix pattern validation error from stix2 lib
✅ The PR is ready for merge 🙌 |
Proposed changes
Related issues
Checklist