Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Recorded Future] handle exception raised when no attachment and no object_refs to report #3079

Merged
merged 3 commits into from
Dec 7, 2024

Conversation

helene-nguyen
Copy link
Member

@helene-nguyen helene-nguyen commented Dec 5, 2024

Proposed changes

  • handle case when no attachement found
  • Add a fake ID in the report as STIX2 doesn’t allowed that a report have no object references and it raise an error when no object_refs exists and we still want to create the report ❌
  • Solution preferred: Create a subclass of Report to have optional object_refs and not required

Related issues

Checklist

  • I consider the submitted work as finished
  • I tested the code for its functionality using different use cases
  • I added/update the relevant documentation (either on github or on notion)
  • Where necessary I refactored code to improve the overall quality

Further comments

@helene-nguyen helene-nguyen added the filigran team use to identify PR from the Filigran team label Dec 5, 2024
@helene-nguyen helene-nguyen self-assigned this Dec 5, 2024
@helene-nguyen helene-nguyen changed the title [connector] handle exception raised when no attachment and no object_refs to report [Recorded Future] handle exception raised when no attachment and no object_refs to report Dec 5, 2024
Copy link
Contributor

@flavienSindou flavienSindou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!
Thank you for the detailed logs and the improvements regarding safer object access.

@helene-nguyen helene-nguyen merged commit 9e007e5 into master Dec 7, 2024
4 checks passed
@helene-nguyen helene-nguyen deleted the bug/2938-rf branch December 7, 2024 06:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
filigran team use to identify PR from the Filigran team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[RecordedFuture]: Exceptions observed during import of Analyst Notes
2 participants