Update default MISP docker-compose.yml to avoid confusion #3063
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Megafredo
reviewed
Dec 6, 2024
| @@ -28,7 +28,7 @@ services: | |||
| - MISP_ENFORCE_WARNING_LIST=false # Optional, enforce warning list in MISP queries | |||
| - MISP_REPORT_TYPE=misp-event # Optional, report_class if creating report for event | |||
| - MISP_IMPORT_FROM_DATE=2000-01-01 # Required, import all event from this date | |||
| - MISP_IMPORT_TAGS=opencti:import,type:osint # Optional, list of tags used for import events | |||
| - MISP_IMPORT_TAGS= # Optional, list of tags used to filter events to import | |||
There was a problem hiding this comment.
Hi @romain-filigran,
Can you also apply this change to the config.yml.sample file ?
I've also looked at the readme but it doesn't seem to be ambiguous.
There was a problem hiding this comment.
You're right. config.yml.sample updated also.
Megafredo
approved these changes
Dec 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Update default MISP docker-compose.yml example configuration to avoid confusion about the purpose of the "MISP_IMPORT_TAGS" env.
Related issues
Checklist
Further comments