Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update importDocument docker-compose.yml #3016

Merged
merged 1 commit into from
Dec 6, 2024
Merged

Update importDocument docker-compose.yml #3016

merged 1 commit into from
Dec 6, 2024

Conversation

romain-filigran
Copy link
Member

@romain-filigran romain-filigran commented Nov 22, 2024 •
edited by helene-nguyen
Loading

Proposed changes

Change the env variable CONNECTOR_ONLY_CONTEXTUAL=false to prevent confusion.

Related issues

Checklist

  • I consider the submitted work as finished
  • I tested the code for its functionality using different use cases
  • I added/update the relevant documentation (either on github or on notion)
  • Where necessary I refactored code to improve the overall quality

Further comments

@romain-filigran
Update importDocument docker-compose.yml
66b4ff4 
Change the environment variable: CONNECTOR_ONLY_CONTEXTUAL=false to enable by default the use of the connector on any way to import files.
@helene-nguyen helene-nguyen added the filigran team use to identify PR from the Filigran team label Dec 5, 2024
@Megafredo
Copy link
Member

Ok I understand and indeed on the config.yml.sample it is also false, but strangely in the readme it is true in description as an example, can you apply the change I validate this PR once done !

@helene-nguyen helene-nguyen linked an issue Dec 6, 2024 that may be closed by this pull request
[Import Document] Update importDocument docker-compose.yml #3087
Closed
@helene-nguyen helene-nguyen merged commit 3d6fd27 into master Dec 6, 2024
4 checks passed
@helene-nguyen helene-nguyen deleted the importdoc-default-conf branch December 6, 2024 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@helene-nguyen helene-nguyen helene-nguyen approved these changes

Assignees
No one assigned
Labels
filigran team use to identify PR from the Filigran team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Import Document] Update importDocument docker-compose.yml
3 participants
@romain-filigran @Megafredo @helene-nguyen