Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[connector] Fix mandiant relationships #2332

Merged
merged 1 commit into from
Jul 11, 2024
Merged

[connector] Fix mandiant relationships #2332

merged 1 commit into from
Jul 11, 2024

Conversation

helene-nguyen
Copy link
Member

@helene-nguyen helene-nguyen commented Jul 11, 2024 •
edited
Loading

Proposed changes

  • Sometimes, relationships in a report is not created. The fix check if there are related entities in the list, add it into definitions and create stix relationship

Checklist

  • I consider the submitted work as finished
  • I tested the code for its functionality using different use cases
  • I added/update the relevant documentation (either on github or on notion)
  • Where necessary I refactored code to improve the overall quality

Further comments

@helene-nguyen helene-nguyen added the filigran team use to identify PR from the Filigran team label Jul 11, 2024
@helene-nguyen helene-nguyen self-assigned this Jul 11, 2024
@SamuelHassine SamuelHassine merged commit 342d344 into master Jul 11, 2024
3 checks passed
@SamuelHassine SamuelHassine deleted the fix/mandiant-relationships branch July 11, 2024 09:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SamuelHassine SamuelHassine Awaiting requested review from SamuelHassine

Assignees

@helene-nguyen helene-nguyen

Labels
filigran team use to identify PR from the Filigran team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@helene-nguyen @SamuelHassine