Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[import-document] make import-document compatible with Analysis connector type #2190

Merged
merged 9 commits into from
Jun 17, 2024
Merged

[import-document] make import-document compatible with Analysis connector type #2190

merged 9 commits into from
Jun 17, 2024

Conversation

JeremyCloarec
Copy link
Contributor

@JeremyCloarec JeremyCloarec commented May 30, 2024 •
edited
Loading

Proposed changes

  • change the connector to be able to handle analysis requests

see OpenCTI-Platform/opencti#7192 for more info

Related issues

Checklist

  • I consider the submitted work as finished
  • I tested the code for its functionality using different use cases
  • I added/update the relevant documentation (either on github or on notion)
  • Where necessary I refactored code to improve the overall quality

Further comments

@JeremyCloarec JeremyCloarec mentioned this pull request May 30, 2024
Merged
5 tasks
@JeremyCloarec JeremyCloarec force-pushed the opencti/6803-chunk1 branch from a3547b6 to 74629fe Compare May 31, 2024 12:05
@JeremyCloarec JeremyCloarec force-pushed the opencti/6803-chunk1 branch from e5e9f07 to 478d909 Compare May 31, 2024 12:22
@JeremyCloarec JeremyCloarec added filigran team use to identify PR from the Filigran team multi-repository When a PR requires several repository changes labels May 31, 2024
@JeremyCloarec JeremyCloarec marked this pull request as ready for review May 31, 2024 15:27
SouadHadjiat
SouadHadjiat reviewed Jun 4, 2024
View reviewed changes
internal-import-file/import-document/src/reportimporter/core.py
parsed_data = parser.parse(raw_text_to_analyze)

parsed_existing_data = self._extract_existing_elements(parsed_data)
# TODO: upload parsed data to analysis
Copy link
Member

@SouadHadjiat SouadHadjiat Jun 4, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the result is not saved for now ? => will be done in next PR

@JeremyCloarec JeremyCloarec merged commit 38f0ace into master Jun 17, 2024
3 checks passed
@JeremyCloarec JeremyCloarec deleted the opencti/6803-chunk1 branch June 17, 2024 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SouadHadjiat SouadHadjiat SouadHadjiat approved these changes

Assignees
No one assigned
Labels
filigran team use to identify PR from the Filigran team multi-repository When a PR requires several repository changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JeremyCloarec @SouadHadjiat