Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update definitions to work with multiformat mpes reader #53

Merged
merged 4 commits into from
Aug 14, 2024

Conversation

rettigl
Copy link
Member

@rettigl rettigl commented Jul 27, 2024

This updates the Nexus config file to work with the new mpes multiformat reader

pyproject.toml Outdated Show resolved Hide resolved
@rettigl rettigl requested a review from domna July 27, 2024 21:39
specsscan/config/NXmpes_arpes_config.json Outdated Show resolved Hide resolved
@domna
Copy link
Contributor

domna commented Jul 28, 2024

Sorry, broke the tests, because I wanted to see if everything works still fine with the changes I did in the pynx branch. Coveralls didn't like re-running the test I think. The test itself, however, seems to be fine (also locally for me).

@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 10387080608

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 90.528%

Totals Coverage Status
Change from base Build 10347673795: 0.0%
Covered Lines: 1510
Relevant Lines: 1668

💛 - Coveralls

@rettigl rettigl merged commit fce1315 into main Aug 14, 2024
5 checks passed
@rettigl rettigl deleted the pynxtools_update branch August 14, 2024 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants