Remove mappings #25
Merged
Remove mappings #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Not sure why tests fail.Maybe the test data don't include units? |
|
An updated config file for specsscan is here: OpenCOMPES/specsanalyzer#53 |
2 tasks
I added the units now. |
Merged
lukaspie
approved these changes
Aug 12, 2024
|
I added some tests for the eln data and updated the config file for it. I also stripped the eln file to only check a certain amount of fields (as this is not the eln example anymore I think it's fine to only use some fields for checking). With this I will merge into the other PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes the mappings and default units, and rather gets values directly from the ELN paths with new mechanism.
Would be good to add some tests for the ELN functionality