Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FFT tool interface #27

Merged
merged 22 commits into from
Apr 19, 2024
Merged

FFT tool interface #27

merged 22 commits into from
Apr 19, 2024

Conversation

Arora0
Copy link
Contributor

@Arora0 Arora0 commented Apr 3, 2024

No description provided.

@Arora0 Arora0 linked an issue Apr 3, 2024 that may be closed by this pull request
Graphic interface for tweaking FFT filtering parameters #6
Closed
@Arora0 Arora0 requested a review from rettigl April 3, 2024 17:22
@coveralls
Copy link
Collaborator

coveralls commented Apr 3, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 8758715458

Details

  • 115 of 125 (92.0%) changed or added relevant lines in 5 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.09%) to 90.373%
Changes Missing Coverage Covered Lines Changed/Added Lines %
specsanalyzer/core.py 77 82 93.9%
specsscan/core.py 19 24 79.17%
Totals Coverage Status
Change from base Build 8685016012: 0.09%
Covered Lines: 1502
Relevant Lines: 1662
💛 - Coveralls

rettigl
rettigl reviewed Apr 16, 2024
View reviewed changes
Copy link
Member

@rettigl rettigl left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functionality looks good now, I would say.
Can you add a test for the function?
And integrate it into the documentation

rettigl
rettigl approved these changes Apr 19, 2024
View reviewed changes
Copy link
Member

@rettigl rettigl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good now

@rettigl rettigl merged commit 046bd3f into main Apr 19, 2024
5 checks passed
@rettigl rettigl deleted the fft-tool branch April 19, 2024 19:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rettigl rettigl rettigl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Graphic interface for tweaking FFT filtering parameters
3 participants
@Arora0 @coveralls @rettigl