Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversion parameters #20

Merged
merged 6 commits into from
Mar 12, 2024
Merged

Conversion parameters #20

merged 6 commits into from
Mar 12, 2024

Conversation

rettigl
Copy link
Member

@rettigl rettigl commented Mar 4, 2024

Adds export of conversion metadata
Adds possibility to convert from conversion metadata
Improves test coverage

Closes #4
Closes #3

@coveralls
Copy link
Collaborator

coveralls commented Mar 4, 2024

Pull Request Test Coverage Report for Build 8255621671

Details

  • 163 of 164 (99.39%) changed or added relevant lines in 9 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+3.9%) to 90.279%

Changes Missing Coverage Covered Lines Changed/Added Lines %
specsanalyzer/core.py 40 41 97.56%
Totals Coverage Status
Change from base Build 8137341366: 3.9%
Covered Lines: 1393
Relevant Lines: 1543

💛 - Coveralls

@rettigl rettigl force-pushed the conversion_parameters branch from 6ba0738 to a1e1946 Compare March 4, 2024 17:51
@rettigl rettigl requested review from Arora0 and puppo85 March 8, 2024 21:16
@rettigl
Copy link
Member Author

rettigl commented Mar 8, 2024

This changes the interface to the conversion routines quite a bit, but the functionality remains the same, as confirmed by the tests

@rettigl rettigl merged commit 0671200 into main Mar 12, 2024
5 checks passed
@rettigl rettigl deleted the conversion_parameters branch March 12, 2024 21:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Store conversion metadata in xarray and in Nexus file Conversion from da parameters
3 participants