-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Binning bug #98
Binning bug #98
Conversation
I implemented now a version close to what I discussed in #95. I did not include the extension of the number of bins by one, but this can be easily added. What it does not is the following:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Again the same problem... 40 files changed.
This PR is about the bug in the binning function, so why does it refactor almost all docstrings of all functions? are these really changes here or do they come from merging other PRs in here?
The code changes I was able to find looked good. But I am certain I missed some.
For the sake of moving on, I will accept this. But lets try keep bug fix PRs to the point.
comments:
- I agree with the removal of the tuple method in the binning arguments. I added far too many options, but that is the default from numpy...
- for other definitions, we can continue our discussion in Binning with Tuple produces unexpected behavior #95 and make smaller, targeted PRs eventually.
My apologies, this is a mistake in rebasing/merging of upstream I apparently made, which overwrites a lot of recent changes in master. Thanks for spotting this. Rebasing and force pushing should solve this, I believe. |
6450199
to
498df55
Compare
Now it is properly rebased, I believe. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! now I managed to read through easily! 😄
looks good to me!
Before merging this, I suggest we finish the discussion of what we want the bins, ranges and tuples functionalities to do, and implement this. At the moment it is np.linspace(r[0], r[1], b, endpoints=False). This produces the same number of points as you give, and with the stepping one might expect (range difference/bins). However, without the last point. |
I think this is a good definition. It kind of sounds pythonic, when you think of how |
b66b51c
to
69c14ab
Compare
I opened an issue for further improvements, and am mergin this. |
Just setting up PR for #95 so we can figure this out. I came with a rough fix that shouldn't be used.
Note: Build will fail since test is testing num_steps.