Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update widths of figures #563

Merged
merged 5 commits into from
Mar 5, 2025
Merged

Update widths of figures #563

merged 5 commits into from
Mar 5, 2025

Conversation

zain-sohail
Copy link
Member

No description provided.

@coveralls
Copy link
Collaborator

coveralls commented Mar 2, 2025 •
edited
Loading

Pull Request Test Coverage Report for Build 13640068666

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 3 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.04%) to 92.236%
Files with Coverage Reduction New Missed Lines %
src/sed/binning/numba_bin.py 3 87.62%
Totals Coverage Status
Change from base Build 13498273640: -0.04%
Covered Lines: 7793
Relevant Lines: 8449
💛 - Coveralls

rettigl
rettigl requested changes Mar 3, 2025
View reviewed changes
Copy link
Member

@rettigl rettigl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Figures appear a bit odd-shaped at places, in particular this one:
image
I suggest to keep similar aspect ratios as before, and just scale down.

@zain-sohail zain-sohail requested a review from rettigl March 3, 2025 15:47
rettigl
rettigl approved these changes Mar 3, 2025
View reviewed changes
Copy link
Member

@rettigl rettigl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be fixed now.

@zain-sohail zain-sohail merged commit f1bb527 into main Mar 5, 2025
7 checks passed
@zain-sohail zain-sohail deleted the fig-width branch March 5, 2025 22:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rettigl rettigl rettigl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zain-sohail @coveralls @rettigl