Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update tests for env variables #553

Merged
merged 1 commit into from
Jan 20, 2025
Merged

update tests for env variables #553

merged 1 commit into from
Jan 20, 2025

Conversation

zain-sohail
Copy link
Member

@zain-sohail zain-sohail commented Jan 17, 2025 •
edited
Loading

closes #552

@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 12824544566

Details

  • 26 of 26 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 92.167%
Totals Coverage Status
Change from base Build 12811246523: 0.0%
Covered Lines: 7695
Relevant Lines: 8349
💛 - Coveralls

rettigl
rettigl approved these changes Jan 18, 2025
View reviewed changes
Copy link
Member

@rettigl rettigl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't understand all details, but it fixes the problem, and tests still pass, so LGTM

@zain-sohail zain-sohail merged commit ab5adac into v1_feature_branch Jan 20, 2025
4 checks passed
@zain-sohail zain-sohail deleted the fix-552 branch January 20, 2025 21:59
@rettigl rettigl mentioned this pull request Jan 20, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rettigl rettigl rettigl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zain-sohail @coveralls @rettigl