-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New tutorials for hextof #518
Conversation
Pull Request Test Coverage Report for Build 11940522307Details
💛 - Coveralls |
Can you clean up all not required files, remove output from notebooks, and make sure tests pass? Also, is it necessary to have different versions of config files, or can they just be updated also for the old example? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are still some unused files (utils.py), and a lot of code in the Notebooks is rather redundant with other tutorials (energy calibration, saving, etc.), and not required for what you want to show. Also, it does not work in the current form outside maxwell (or even your account).
I restructured and streamlined the notebooks to some extend, see PR #524
After we agree on a version, this should still be rebased and all older commits with notebook output removed, integrated into the docs, made sure they compile during docs building, etc.
@rettigl thanks for cleaning up everything - your fixes branch now looks quite straightforward. Also, I like this comparison of both calibration methods, which at the end shows that the 4.5 eV range with SB calibration is even better than the 3 eV range with bias - it gives a proper 2.2 eV difference between W4f peaks. In case we want to have also metadata - I can download a recent version from SciCat as json file that we can add to work outside of Maxwell. |
I suggest to implement such methods into the framework of the calibrator classes. I remember @steinnymir started working on such methods at some point. See #270
We can add this later eventually if we want to, I don't think it that important for these tutorials, which aim at a specific functionality. I will merge the fixes branch then here, rebase, and integrate these tutorials into the docs structure when I find time. |
This utils.py comes from Steinn and I am/was just trying to finalize it :)
Yes, I agree that this is not so important here.
Just a small correction before you merge to No.11 notebook for SB calibration cell:
|
df48bd0
to
b56605e
Compare
…D using new dataset from Zenodo Added one more notebook for HEXTOF - energy calibration using SB Removed some copy/not needed files Cleaned up all not required files clear notebook output clean up tutorials add reference energy calibration, and allow using processor function with preview remove unnecessary stuff add energy comparison remove kernel specs further clean up spell fixes remove outdated config file
b56605e
to
4d4000b
Compare
Three more tutorials for HEXTOF using new W(110) data sets from the public beamtime folder or also from Zenodo (https://zenodo.org/records/12609441):