Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sxp fixes for new daq #510

Merged
merged 11 commits into from
Nov 11, 2024
Merged

Sxp fixes for new daq #510

merged 11 commits into from
Nov 11, 2024

Conversation

rettigl
Copy link
Member

@rettigl rettigl commented Oct 17, 2024

This PR brings in the changes to the sxp reader required for the new daq, while keeping compatibility to the old example tutorial.

It also adds the example dataset for sxp, and adds this to the documentation

@rettigl rettigl force-pushed the sxp_fixes-for-new-daq branch from f70810f to ff2a104 Compare October 17, 2024 22:17
@coveralls
Copy link
Collaborator

coveralls commented Oct 17, 2024

Pull Request Test Coverage Report for Build 11783158442

Details

  • 15 of 17 (88.24%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.006%) to 91.942%

Changes Missing Coverage Covered Lines Changed/Added Lines %
sed/loader/sxp/loader.py 15 17 88.24%
Totals Coverage Status
Change from base Build 11781677796: -0.006%
Covered Lines: 6492
Relevant Lines: 7061

💛 - Coveralls

@rettigl rettigl force-pushed the sxp_fixes-for-new-daq branch from ff2a104 to ad37fa9 Compare October 17, 2024 22:21
@rettigl rettigl requested a review from zain-sohail October 22, 2024 17:57
@rettigl rettigl mentioned this pull request Oct 25, 2024
Copy link
Member

@zain-sohail zain-sohail left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor suggestions. Everything works as intended.

Also side question, but have you attempted to use their xfel's own dataloader? Perhaps the data reduction can be done from that (if it works) and the further processing in SED, so we don't have to support updating the loader whenever there is a change.

tutorial/5_sxp_workflow.ipynb Outdated Show resolved Hide resolved
tutorial/5_sxp_workflow.ipynb Show resolved Hide resolved
tutorial/5_sxp_workflow.ipynb Show resolved Hide resolved
tutorial/5_sxp_workflow.ipynb Show resolved Hide resolved
docs/scripts/build_sxp_parquets.py Show resolved Hide resolved
@rettigl
Copy link
Member Author

rettigl commented Nov 11, 2024

Also side question, but have you attempted to use their xfel's own dataloader? Perhaps the data reduction can be done from that (if it works) and the further processing in SED, so we don't have to support updating the loader whenever there is a change.

This is something to look at after v1. For the last beam time, I have indeed used the parquet files directly, that are created using the SXP machinery.

@rettigl rettigl mentioned this pull request Nov 11, 2024
@rettigl rettigl merged commit b219760 into main Nov 11, 2024
8 checks passed
@rettigl rettigl deleted the sxp_fixes-for-new-daq branch November 11, 2024 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants