-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sxp fixes for new daq #510
Conversation
f70810f
to
ff2a104
Compare
Pull Request Test Coverage Report for Build 11783158442Details
💛 - Coveralls |
ff2a104
to
ad37fa9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some minor suggestions. Everything works as intended.
Also side question, but have you attempted to use their xfel's own dataloader? Perhaps the data reduction can be done from that (if it works) and the further processing in SED, so we don't have to support updating the loader whenever there is a change.
This is something to look at after v1. For the last beam time, I have indeed used the parquet files directly, that are created using the SXP machinery. |
This PR brings in the changes to the sxp reader required for the new daq, while keeping compatibility to the old example tutorial.
It also adds the example dataset for sxp, and adds this to the documentation