Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Spelling fixes for main #454

Merged
merged 3 commits into from
Jul 2, 2024
Merged

Spelling fixes for main #454

merged 3 commits into from
Jul 2, 2024

Conversation

rettigl
Copy link
Member

@rettigl rettigl commented Jun 29, 2024

This PR supercedes #450, and adds spell fixes, pre-commit hook and action for main.
Might require some manual work for rebasing of the v1_feature_branch after merging.

@rettigl rettigl requested a review from zain-sohail June 29, 2024 18:29
@coveralls
Copy link
Collaborator

coveralls commented Jun 29, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9726111549

Details

  • 7 of 7 (100.0%) changed or added relevant lines in 4 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 91.888%
Totals Coverage Status
Change from base Build 9652384660: 0.0%
Covered Lines: 6457
Relevant Lines: 7027
💛 - Coveralls

@rettigl rettigl force-pushed the spelling_fixes_for_main branch from bdacf19 to 330ce24 Compare June 29, 2024 18:43
@coveralls
Copy link
Collaborator

coveralls commented Jun 29, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9726202970

Details

  • 7 of 7 (100.0%) changed or added relevant lines in 4 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 91.888%
Totals Coverage Status
Change from base Build 9652384660: 0.0%
Covered Lines: 6457
Relevant Lines: 7027
💛 - Coveralls

zain-sohail
zain-sohail approved these changes Jul 1, 2024
View reviewed changes
Copy link
Member

@zain-sohail zain-sohail left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally fine but I noticed that the spell check marks British spelling as incorrect and prefers American. Would be good if both are accepted. But if we want to stick to American, also fine.

@rettigl
Copy link
Member Author

rettigl commented Jul 2, 2024

Generally fine but I noticed that the spell check marks British spelling as incorrect and prefers American. Would be good if both are accepted. But if we want to stick to American, also fine.

I also allow British English now, but still keep the changes I made to American English for consistency.

@rettigl rettigl merged commit 2bf9a13 into main Jul 2, 2024
3 checks passed
@rettigl rettigl deleted the spelling_fixes_for_main branch July 2, 2024 07:23
@coveralls
Copy link
Collaborator

coveralls commented Jul 2, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9756635208

Details

  • 7 of 7 (100.0%) changed or added relevant lines in 4 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 91.888%
Totals Coverage Status
Change from base Build 9652384660: 0.0%
Covered Lines: 6457
Relevant Lines: 7027
💛 - Coveralls

@rettigl rettigl mentioned this pull request Jul 2, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zain-sohail zain-sohail zain-sohail approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rettigl @coveralls @zain-sohail