Update dask version #448
Merged
Update dask version #448
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 9651968197Details
💛 - Coveralls |
rettigl
force-pushed
the
update_dask_version
branch
from
5c55f95 to
6f123a9
Compare
Pull Request Test Coverage Report for Build 9652411782Details
💛 - Coveralls |
Pull Request Test Coverage Report for Build 9652821299Details
💛 - Coveralls |
|
I saw some threads on xarray about ffill algorithms and maybe they help in not using map_overlap. Putting it here because it's related |
|
Generally I find the error occuring in the current v1 branch as well |
|
It depends on the dask version, not our code. Did you check the dask version you were using? |
Yes you are right. The 2024 version seems to cause this. Would be great to use the new optimizer they have but seems we have to figure things on our side. |
rettigl
force-pushed
the
update_dask_version
branch
from
a2ba530 to
3ea7dcc
Compare
Pull Request Test Coverage Report for Build 11300006146Details
💛 - Coveralls |
rettigl
force-pushed
the
update_dask_version
branch
from
3ea7dcc to
1aa4a83
Compare
|
Disabled dataframe.query-planning for now as workaround, to not have to limit the python version anymore. |
zain-sohail
approved these changes
Oct 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The changes to the dfops in #411 allow to pass the tests with dask2024.6.2, however there are random failures during binning (see dask/dask#11200). This requires further inspection.