Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Review fixes #435

Merged
merged 2 commits into from
Jun 23, 2024
Merged

Review fixes #435

merged 2 commits into from
Jun 23, 2024

Conversation

rettigl
Copy link
Member

@rettigl rettigl commented Jun 23, 2024

This adds some fixes addressed after another review of PR #427

@coveralls
Copy link
Collaborator

coveralls commented Jun 23, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9635691951

Details

  • 2 of 2 (100.0%) changed or added relevant lines in 1 file are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.03%) to 91.857%
Files with Coverage Reduction New Missed Lines %
sed/calibrator/momentum.py 2 86.78%
Totals Coverage Status
Change from base Build 9633480793: -0.03%
Covered Lines: 6430
Relevant Lines: 7000
💛 - Coveralls

@rettigl rettigl merged commit ed89063 into v1_feature_branch Jun 23, 2024
5 checks passed
@rettigl rettigl deleted the python-upgrade-39 branch June 23, 2024 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rettigl @coveralls