Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add benchmarks for dataframe computation #422

Merged
merged 5 commits into from
Jun 22, 2024
Merged

add benchmarks for dataframe computation #422

merged 5 commits into from
Jun 22, 2024

Conversation

rettigl
Copy link
Member

@rettigl rettigl commented Jun 19, 2024

Adds a benchmark for computing a one-partition dataframe for each supported reader

@coveralls
Copy link
Collaborator

coveralls commented Jun 19, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9587748364

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 91.962%
Totals Coverage Status
Change from base Build 9572471667: 0.0%
Covered Lines: 6464
Relevant Lines: 7029
💛 - Coveralls

@coveralls
Copy link
Collaborator

coveralls commented Jun 19, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9587824573

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 91.962%
Totals Coverage Status
Change from base Build 9572471667: 0.0%
Covered Lines: 6464
Relevant Lines: 7029
💛 - Coveralls

@coveralls
Copy link
Collaborator

coveralls commented Jun 19, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9587905555

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 91.962%
Totals Coverage Status
Change from base Build 9572471667: 0.0%
Covered Lines: 6464
Relevant Lines: 7029
💛 - Coveralls

@rettigl rettigl force-pushed the reader_benchmarks branch from 5d6f894 to 3c2a4ce Compare June 19, 2024 20:46
@coveralls
Copy link
Collaborator

coveralls commented Jun 19, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9587973485

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 91.962%
Totals Coverage Status
Change from base Build 9572471667: 0.0%
Covered Lines: 6464
Relevant Lines: 7029
💛 - Coveralls

@coveralls
Copy link
Collaborator

coveralls commented Jun 19, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9588036057

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 91.962%
Totals Coverage Status
Change from base Build 9572471667: 0.0%
Covered Lines: 6464
Relevant Lines: 7029
💛 - Coveralls

zain-sohail
zain-sohail approved these changes Jun 22, 2024
View reviewed changes
Copy link
Member

@zain-sohail zain-sohail left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I understand that this is to check the performance for when we update to new code?

If we also want to compare performance between the different loaders, I guess the channel count should be same across them.

@rettigl rettigl merged commit cc635f1 into main Jun 22, 2024
6 checks passed
@rettigl rettigl deleted the reader_benchmarks branch June 22, 2024 23:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zain-sohail zain-sohail zain-sohail approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rettigl @coveralls @zain-sohail