-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update hextof tutorial notebook #421
Conversation
Pull Request Test Coverage Report for Build 9583236814Details
💛 - Coveralls |
Pull Request Test Coverage Report for Build 9599766532Details
💛 - Coveralls |
Pull Request Test Coverage Report for Build 9599766183Details
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't like the change of the folder_config. and indeed it will not work as you intend if there is another sed_config.yaml in the current folder (e.g. if you run tutorial 2 before...)
Pull Request Test Coverage Report for Build 9845689159Details
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Mostly minor changes so that users on Maxwell don't end up downloading data when it's available in the public beamtimes. The user folder is only 30 GB.
I have opted to use non-default calibration file and put that as user_config keyword. I am not certain if this is the ideal way but this can be discussed