Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update hextof tutorial notebook #421

Merged
merged 5 commits into from
Jul 8, 2024
Merged

Update hextof tutorial notebook #421

merged 5 commits into from
Jul 8, 2024

Conversation

zain-sohail
Copy link
Member

Mostly minor changes so that users on Maxwell don't end up downloading data when it's available in the public beamtimes. The user folder is only 30 GB.

I have opted to use non-default calibration file and put that as user_config keyword. I am not certain if this is the ideal way but this can be discussed

@coveralls
Copy link
Collaborator

coveralls commented Jun 19, 2024

Pull Request Test Coverage Report for Build 9583236814

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 91.962%

Totals Coverage Status
Change from base Build 9572471667: 0.0%
Covered Lines: 6464
Relevant Lines: 7029

💛 - Coveralls

@coveralls
Copy link
Collaborator

coveralls commented Jun 20, 2024

Pull Request Test Coverage Report for Build 9599766532

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 91.962%

Totals Coverage Status
Change from base Build 9572471667: 0.0%
Covered Lines: 6464
Relevant Lines: 7029

💛 - Coveralls

@coveralls
Copy link
Collaborator

coveralls commented Jun 20, 2024

Pull Request Test Coverage Report for Build 9599766183

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 91.962%

Totals Coverage Status
Change from base Build 9572471667: 0.0%
Covered Lines: 6464
Relevant Lines: 7029

💛 - Coveralls

Copy link
Member

@rettigl rettigl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't like the change of the folder_config. and indeed it will not work as you intend if there is another sed_config.yaml in the current folder (e.g. if you run tutorial 2 before...)

tutorial/4_hextof_workflow.ipynb Outdated Show resolved Hide resolved
tutorial/4_hextof_workflow.ipynb Outdated Show resolved Hide resolved
tutorial/4_hextof_workflow.ipynb Outdated Show resolved Hide resolved
@zain-sohail zain-sohail requested a review from rettigl July 8, 2024 14:11
@coveralls
Copy link
Collaborator

coveralls commented Jul 8, 2024

Pull Request Test Coverage Report for Build 9845689159

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 91.888%

Totals Coverage Status
Change from base Build 9835772801: 0.0%
Covered Lines: 6457
Relevant Lines: 7027

💛 - Coveralls

Copy link
Member

@rettigl rettigl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zain-sohail zain-sohail merged commit 7028a10 into main Jul 8, 2024
6 checks passed
@zain-sohail zain-sohail deleted the update-hextof-tutorial branch July 8, 2024 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants