-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Example for FLASH nexus conversion/metadata collection #420
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Comments on the changes I did and TODOs
Pull Request Test Coverage Report for Build 9811460900Details
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Dima sent me the updated nexus config file so I am just putting it here
Pull Request Test Coverage Report for Build 11784465431Details
💛 - Coveralls |
682d3d7
to
f1e11da
Compare
@kutnyakhov @zain-sohail Running the current state (rebased to master) outside maxwell results in the following warnings during saving:
I.e. a huge number of metadata is not being found. Running the same on Maxwell results in an error when trying to load the metadata file:
|
@rettigl for FLASH data we are using the SciCat catalogue for the metadata. In order to get them you need to get your personal
Also, as discussed during last meeting, we still have problems that some user info is missing and IT guys are working to solve this problem for future, but for now we have to also read additionally beamtime metadata file:
and accordingly, add this info while reading data
|
For general usage that is fine, but for the example we need to provide a solution that works without this, i.e. put the scicat metadata into a file and provide it with the example data. This exists in the zenodo upload, but not in the data on the maxwell cluster, thus it fails there.
This file again is not part of the upload on zenodo, so again it would fail if you are not on maxwell Even with these additions, there are a lot of metadata not being found by the reader, because the information in the config file is wrong. This should be fixed for this example, that is my point. If some data are not available for this, let's just remove the respective entries and add them later once these data are available. |
@zain-sohail @kutnyakhov I removed everything that does not exist here, and corrected to reflect the paths in the metadata files. |
This PR is intended for discussing necessary/missing changes to the FLASH metadata structure for conversion to nexus.