Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Calibration creation date #321

Merged
merged 13 commits into from
Feb 21, 2024
Merged

Calibration creation date #321

merged 13 commits into from
Feb 21, 2024

Conversation

rettigl
Copy link
Member

@rettigl rettigl commented Jan 4, 2024

This PR:

  • unifies the interface for calibrations, corrections and offsets, and their saving and loading.
  • adds time-stamps for the creation of the respective correction, and displays them when loading (optional).
  • adds Saving/loading procedures for momentum transformations/pose adjustments

closes #145
closes #149

@coveralls
Copy link
Collaborator

coveralls commented Jan 4, 2024

Pull Request Test Coverage Report for Build 7991449446

Details

  • 597 of 652 (91.56%) changed or added relevant lines in 8 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.6%) to 91.137%

Changes Missing Coverage Covered Lines Changed/Added Lines %
tests/calibrator/test_momentum.py 9 10 90.0%
sed/calibrator/delay.py 82 87 94.25%
sed/calibrator/energy.py 90 97 92.78%
sed/calibrator/momentum.py 108 115 93.91%
sed/core/processor.py 212 247 85.83%
Files with Coverage Reduction New Missed Lines %
sed/core/dfops.py 1 84.08%
Totals Coverage Status
Change from base Build 7963843656: 0.6%
Covered Lines: 5933
Relevant Lines: 6510

💛 - Coveralls

@rettigl rettigl force-pushed the calibration_creation_date branch from 0e01998 to 4fc8c3d Compare January 5, 2024 10:18
@rettigl rettigl force-pushed the calibration_creation_date branch from 03ab8c8 to 4fc3b52 Compare January 7, 2024 10:14
@rettigl
Copy link
Member Author

rettigl commented Jan 9, 2024

This has grown relatively large again, but should be well covered by tests. @steinnymir please inspect the changed structure of the offset functions in energy and delay correctors (functionality should be the same and/or fixed according to docstring)

@rettigl rettigl merged commit 7aebd22 into main Feb 21, 2024
6 checks passed
@rettigl rettigl deleted the calibration_creation_date branch February 21, 2024 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants