Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ruff linting #315

Merged
merged 4 commits into from
Dec 24, 2023
Merged

Ruff linting #315

merged 4 commits into from
Dec 24, 2023

Conversation

rettigl
Copy link
Member

@rettigl rettigl commented Dec 19, 2023

Replace flake8, black, pylint and pycodestyle by ruff
Also adds mypy to the precommit hook

@rettigl
Setup ruff as linter + formatter
66ef3a8 
move mypy options into pyproject.toml
Add mypy to pre-commit hooks
@rettigl
add ruff badge
2f5afc2
@rettigl
update poetry.lock file
e5712ad
@rettigl
add additional ruff options and correct path
70c29f3 
reformat files under sed
@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 7268378914

  • 13 of 14 (92.86%) changed or added relevant lines in 5 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.003%) to 90.659%
Changes Missing Coverage Covered Lines Changed/Added Lines %
sed/loader/mirrorutil.py 1 2 50.0%
Totals Coverage Status
Change from base Build 7267370699: 0.003%
Covered Lines: 5610
Relevant Lines: 6188
💛 - Coveralls

zain-sohail
zain-sohail approved these changes Dec 21, 2023
View reviewed changes
Copy link
Member

@zain-sohail zain-sohail left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rettigl rettigl merged commit 28a95ca into main Dec 24, 2023
5 checks passed
@rettigl rettigl deleted the ruff_linting branch December 24, 2023 20:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zain-sohail zain-sohail zain-sohail approved these changes

@steinnymir steinnymir Awaiting requested review from steinnymir

@daviddoji daviddoji Awaiting requested review from daviddoji

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rettigl @coveralls @zain-sohail