Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automation improvements #280

Merged
merged 1 commit into from
Nov 18, 2023
Merged

Automation improvements #280

merged 1 commit into from
Nov 18, 2023

Conversation

zain-sohail
Copy link
Member

No description provided.

@zain-sohail
Copy link
Member Author

closes #279

@zain-sohail zain-sohail merged commit cb8eded into main Nov 18, 2023
@zain-sohail zain-sohail deleted the automation-improvements branch November 18, 2023 17:34
@rettigl
Copy link
Member

rettigl commented Nov 19, 2023

The workflows should also run if one updates the workflow files...

@zain-sohail
Copy link
Member Author

The workflows should also run if one updates the workflow files...

Shouldn't be the case. The workflows don't check or do anything with the workflow files. Most of our workflows are based on checking sed or tests folder (so they can be further restricted). And documentation is based on sed and tutorial. Build is based on toml and sed.

If you mean we should be able to test the workflows, I'd suggest we add a manual run option.

@rettigl
Copy link
Member

rettigl commented Nov 19, 2023

What I mean is that a workflow should run if itself is being updated. Today, the documentation workflow was broken, and it did not run when I fixed it.

@zain-sohail
Copy link
Member Author

I get that. I can add for each workflow this option.

Currently pytest and pylint run on all pushes. Shall that also be restricted to certain folders?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants