Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Time stamped data #227

Merged
merged 11 commits into from
Nov 21, 2023
Merged

Time stamped data #227

merged 11 commits into from
Nov 21, 2023

Conversation

rettigl
Copy link
Member

@rettigl rettigl commented Nov 1, 2023

This PR adds code to add time stamped data to the dataframe using interpolation

@rettigl rettigl mentioned this pull request Nov 1, 2023
Closed
@rettigl
Copy link
Member Author

rettigl commented Nov 1, 2023

Closes #27

@rettigl rettigl linked an issue Nov 1, 2023 that may be closed by this pull request
Include time-stamped external data #27
Closed
@coveralls
Copy link
Collaborator

coveralls commented Nov 1, 2023 •
edited
Loading

Pull Request Test Coverage Report for Build 6941837369

  • 79 of 90 (87.78%) changed or added relevant lines in 5 files are covered.
  • 3 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.06%) to 90.537%
Changes Missing Coverage Covered Lines Changed/Added Lines %
sed/loader/mpes/loader.py 17 22 77.27%
sed/core/processor.py 15 21 71.43%
Files with Coverage Reduction New Missed Lines %
sed/binning/numba_bin.py 3 87.74%
Totals Coverage Status
Change from base Build 6929569709: -0.06%
Covered Lines: 5559
Relevant Lines: 6140
💛 - Coveralls

@rettigl rettigl requested a review from steinnymir November 1, 2023 21:06
steinnymir
steinnymir approved these changes Nov 3, 2023
View reviewed changes
Copy link
Member

@steinnymir steinnymir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be nice to see an actual test case. The tests are rather limited in showing use cases. Otherwise looks good, from what I can see without testing further.

@rettigl
Copy link
Member Author

rettigl commented Nov 3, 2023

Would be nice to see an actual test case.

For the test data we have I unfortunately don't have meaningful timestamped data to add. I could maybe upload a second dataset.

@rettigl rettigl force-pushed the time_stamped_data2 branch from 421a0df to 772d137 Compare November 5, 2023 12:23
rettigl added 11 commits November 19, 2023 22:29
@rettigl
basic function for adding time-stamped data to dataframe
9f09984
@rettigl
add tests, and limit function to only work with dask dataframes becau…
5c352dd 
…se it uses map_partitions
@rettigl
move determination of start and end time stamps and archiver data ext…
06a2015 
…raction into seperate functions
@rettigl
add processor function to add time-stamped data either from directly …
685bcbc 
…provided data or from data extracted from an EPICS archiver instance, and add tests for it
@rettigl
fix time stamps of timed data frame in mpes loader
d4684dc
@rettigl
add time-stamped data to timed dataframe
a732be6
@rettigl
use independent loader for energy corrector class
aa9f912 
correct k-distance for k calibration
@rettigl
fix linting
b9ff427
@rettigl
fix missing endpoint in bin_ranges in momentum corrector
bdd9e89
@rettigl
update momentum scaling
dee6366
@rettigl
add notebook and documentation
5dc117a
@rettigl rettigl merged commit 59f095f into main Nov 21, 2023
5 checks passed
@rettigl rettigl deleted the time_stamped_data2 branch November 21, 2023 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@steinnymir steinnymir steinnymir approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Include time-stamped external data
3 participants
@rettigl @coveralls @steinnymir