Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flash energy calibration #152

Merged
merged 3 commits into from
Oct 24, 2023
Merged

Flash energy calibration #152

merged 3 commits into from
Oct 24, 2023

Conversation

rettigl
Copy link
Member

@rettigl rettigl commented Sep 14, 2023

This PR is for developing energy calibration methods for flash.
So far, it contains an example notebook on how to load the provided FLASH energy calibration run into the existing energy calibration workflow in the processor, and demonstrates how to use the existing energy calibration functions.

@coveralls
Copy link
Collaborator

coveralls commented Sep 14, 2023

Pull Request Test Coverage Report for Build 6286590565

  • 32 of 32 (100.0%) changed or added relevant lines in 2 files are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.02%) to 90.543%

Files with Coverage Reduction New Missed Lines %
sed/calibrator/energy.py 2 91.86%
Totals Coverage Status
Change from base Build 6285960524: 0.02%
Covered Lines: 4203
Relevant Lines: 4642

💛 - Coveralls

@rettigl rettigl force-pushed the flash_energy_calibration branch from 6d0d13f to 6c6800d Compare September 14, 2023 22:16
…dd example notebook to use the energy calibrator workflow with FLASH data
@rettigl rettigl force-pushed the flash_energy_calibration branch from 6c6800d to 2322fb7 Compare September 23, 2023 21:41
@rettigl rettigl force-pushed the flash_energy_calibration branch from 2322fb7 to 01502fb Compare September 23, 2023 21:59
@steinnymir
Copy link
Member

What are the changes introduced is this PR?
should I merge them into #169 where we are developing hextof related calibrations and corrections?

@rettigl
Copy link
Member Author

rettigl commented Oct 12, 2023

It contains the energy calibration notebook by dima, which I modified to use the methods from mpes to optain the parameters, and do the energy calibration. For this I had to also modify the code somewhat to allow ingesting the bias series data from externally binned arrays, rather than only binning internally. This was on the agenda anyways.
The notebook could either stay a tutorial notebook, or be removed, otherwise this could be merged to main, as it closes #146.
It also provides a first demonstrator for #102, albeit without the energy shift by bias/photon energy, etc, and potential changes you might want to introduce.

@rettigl
Copy link
Member Author

rettigl commented Oct 12, 2023

It might not be a good tutorial notebook, as the data are not publically available. We could upate it with the now-available public data.

@steinnymir
Copy link
Member

ok, so these changes will be necessary to run the energy calibration functions.
I would merge this in #169 then. is this tested and ready to go?

@rettigl
Copy link
Member Author

rettigl commented Oct 12, 2023

Apart from the notebook, this is has tests and works. It's a small change. As I said, after review can be merged to main to close #146 and then rebase #169, that would be my preferred way

@steinnymir
Copy link
Member

Can we merge this PR so I can implement it in #169 ?

@rettigl rettigl merged commit 1ad0549 into main Oct 24, 2023
@rettigl rettigl deleted the flash_energy_calibration branch October 24, 2023 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants